Make useZoomPan initialize position on mount #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Position and some other values are now initialized on mount and memoized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
useZoomPanto make sure that position is initialized to the correct values on the first render, instead of the value{ x: 0, y: 0, k: 1 }.The problem with using
{ x: 0, y: 0, k: 1 }is that when it's used together with CSS transitions the map transitions from that value to the correct one immediately when loaded instead of just starting with the correct position without transitioning.This PR fixes #228
I have tested this with my scenario which is a pretty simple one and it seems to work as expected but it might need some more testing in other use cases.
I hope this works well and can be merged since it would help me a lot! Let me know if anything needs to be explained or changed.