Skip to content

Fix readme and add options documentation #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

igorechek06
Copy link
Contributor

I just stole the documentation.

@cla-bot cla-bot bot added the cla-signed label Apr 16, 2025
@valentinegb
Copy link
Collaborator

I'm not sure if this is a good idea. JDTLS updates independently of the extension and if we keep documentation on JDTLS it can very easily become out-of-date and inaccurate. Also, users of the extension can use whatever version of JDTLS they want, so we should leave it up to them to find the documentation for the right version.

### `java.format.tabSize`

- **Description**: Tab size
- **Default**: true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is rather 4 I guess?!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it's my typo

@valentinegb
Copy link
Collaborator

I'm not sure if this is a good idea. JDTLS updates independently of the extension and if we keep documentation on JDTLS it can very easily become out-of-date and inaccurate. Also, users of the extension can use whatever version of JDTLS they want, so we should leave it up to them to find the documentation for the right version.

I'm open to being convinced that I'm wrong, hence why I've left the issue open thus far, but if my concerns aren't addressed I'm going to close this without merging eventually.

@lukejans
Copy link

Hi everyone,

Thanks for opening this discussion! I’ve been trying to clarify exactly which features the zed-java extension supports, but haven’t found much documentation yet. Since I installed it, I’ve been experimenting with code actions and I’m not sure if they’re actually supported or if I’ve misconfigured something.

Here’s what I’m trying to use to enable the qualifyMembers and qualifyStaticMembers cleanup actions:

{
  "jdtls": {
    "initialization_options": {
      "settings": {
        "java": {
          "cleanup": {
            "actions": ["qualifyMembers", "qualifyStaticMembers"],
            "actionsOnSave": ["qualifyMembers", "qualifyStaticMembers"]
          }
        }
      }
    }
  }
}

I based this on the Red Hat vscode‑java extension and the eclipse.jdt.ls initialization guide, but I haven’t seen any effect in Zed. Could someone confirm whether code actions (like cleanup) are supported by zed-java? If they’re not yet implemented, any pointers on where to find documentation—or proposals for adding some to avoid this problem—would be hugely appreciated.

Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants