Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix widthclass and size issues #24

Open
RustoMCSpit opened this issue Sep 29, 2024 · 8 comments
Open

fix widthclass and size issues #24

RustoMCSpit opened this issue Sep 29, 2024 · 8 comments

Comments

@RustoMCSpit
Copy link

"The WidthClass is set to 400 instead of 300, which breaks cosmic texts fallback stack on Linux. (Also they're really big, for some reason I don't know yet)" zed-industries/zed#15053 (comment)

@notpeter
Copy link
Member

Note

Zed not longer ships Zed Mono and Zed Sans typefaces. This repo is not actively maintained.

That said, I am willing to review community bug-fix PRs and potentially ship an updated release, but this is not my area of expertise and so I can't help much. Personally, I love Zed Mono and would very much love for it to live on.

@RustoMCSpit
Copy link
Author

I love Zed Mono and would very much love for it to live on.

i am going to fanboy a minute and i apologise. it's the best fucking font ive ever seen and i am obsessed with it. it's perfect, it can not visually be improved. it is the pinnacle of fonts.

@RustoMCSpit
Copy link
Author

Note

Zed not longer ships Zed Mono and Zed Sans typefaces. This repo is not actively maintained.

That said, I am willing to review community bug-fix PRs and potentially ship an updated release, but this is not my area of expertise and so I can't help much. Personally, I love Zed Mono and would very much love for it to live on.

do you know exactly why it was canned? is the above the only problem with it? im sure someone of your 100000s of users would fix it (or i can if i know what to look for). what exactly were all the reasons to get rid of it?

@RustoMCSpit
Copy link
Author

RustoMCSpit commented Sep 30, 2024

but this is not my area of expertise.

would anyone on the team be knowledgable in knowing what needs to be fixed? a simple checklist would do.

@notpeter
Copy link
Member

notpeter commented Sep 30, 2024

I think it's possible some of the problems may have been fixed upstream: be5invis/Iosevka. I would try to use the private-build-plans.toml with a newer release of Iosevka.

I don't have a checklist, but here's one which came up in a quick issue search:

Also the size is also out of control.
IBM Plex Mono Regular is 134kb
BlexMonoNerdFont Regular is 2.2MB (includes 2MB of Nerd Font Glyphs)
FiraCode is 290kb.
JetBrains Mono is 274kb.
Zed Mono is 3.3MB without Nerd Font Glyphs 🫤
Practically its 4x that (regular, bold, italic, bold italic) so 13.6MB. Eek.

@RustoMCSpit
Copy link
Author

i'll look into this later, if you can @ anyone who knows more that'd be great. thank you so much (not)peter.

@RustoMCSpit
Copy link
Author

looking into this now but i dont know if zed's default was sans or mono. i'll try building with the .toml if you cant do that on your end with a github action and seeing if that works.

@notpeter
Copy link
Member

notpeter commented Oct 4, 2024

We shipped both, but Zed Mono was the default. See default.json in the diff when we switched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants