-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from Zed fonts to IBM Plex #13596
Conversation
Ugh, Does this mean zed font is no longer maintained? This new font looks wildly different than the previous one. |
This could have been an opt-in option, no one likes a jarring visual change in product updates. |
agreed, was this out of necessity or was it just an aesthetic choice. regardless, i imagine the old font is no longer included because of download size but even then an opt-in somehow would've been nice rather than everyone being opted-out. does anyone know if the default font was zed sans or zed mono and furthermore were those font set to condensed or regular width by default? |
Installing Zed Sans locally and having it set as the |
Let me share what did it for me:
{
...
"buffer_font_family": "Zed Mono",
"ui_font_family": ".SystemUIFont"
} Also, do check out the settings file change to roll back commits as you may |
Zed auto-infers most of your system fonts, it auto-suggests, as you type in the font you want, as long as you've installed the fonts locally and are editing the right settings field. |
Oh okay, check out Issue 5028 on how to switch between variants and edit the |
Ah, perfect, thank you! |
sounds like there is an error there, make an issue about it? |
Is there a reason for this change? I genuinely prefer
|
such a shame, the zed font is the reason i fell in love with the clean code. Gotta install it manually now |
Thanks @joaokamun — these character pairs seem like strange choices for ligatures, IMO |
Just wonder how to make the "comments" part to be italics font sytle. |
I just figured out, this setting works.
|
can someone compose a full settings copy and paste text that includes all features of the previous font setup
|
Hey! Came here to figure out how to get back to Zed Sans (Extended), and have to say I'm surprised and bummed by this change. I say this as both a developer and a professional designer — Zed Sans was and is great, and it was a strikingly positive first impression when I started using Zed. I'm curious what motivated the change? |
Another option for going back to Zed Mono would be to install the ZedMono Nerd Font from https://github.com/ryanoasis/nerd-fonts/releases/download/v3.2.1/ZedMono.zip Then, configure it as follows in settings.json: That should be it 😄 |
I'm curious, given it sounds like file size was the main concern of the change... I would think to use the built-in UI and monospace fonts for the operating system as the default and let folks overwrite it in their settings; I'm sure it's often the first setting most folks will change after installing Zed. |
Totally agree! I love Zed Sans. If file size is the primary concern, could the font's (optional) installation be part of the onboarding flow instead? Post-install when selecting default keybindings and choosing whether to have vim mode enabled, "Install and apply Zed fonts" could be one of those options. |
Was size the major factor? The Zed fonts are ~16x larger but also contain ~28x more glyphs. If size were the driver, you could build the fonts with a reduced glyph set. In any case, I'd be curious to get @iamnbutler's take. |
this seems like a great idea! i can make it an issue if wanted or we can continue to discuss it here? |
Don't know where to leave this issue, but the ligatures don't match the curly braces, which looks pretty awful: Also I mentioned elsewhere, but at least with Elixir code, you end up with mostly italic code: And while I agree that fonts are a personal preference... the new IBM Plex is one of my least favorite fonts I've ever seen. I'm not being hyperbolic when I say I physically recoiled to it more as the week went on. YMMV but I know Zed is all about FTUX and UI. I would have to imagine this font will negatively impact the FTUX for most people. (I've reinstalled the old Zed font which I genuinely enjoyed, so I'm happy, I'm not expecting this decision to be reversed. Only leaving as feedback.) EDIT: toned down my language, I think it came out too strong. Genuinely trying to be helpful, not dogpile. Love all the amazing work at Zed, just not this font <3 |
@barrelltech I don't see anything italicized in the Elixir files I'm looking at. 🤷 fwiw, I expected to hate this font since that seems to be the sentiment here, but I like it. I've been using FiraCode Nerd Font Mono for a couple years and this doesn't seem like much of a departure from that. I'd probably switch to it, but running into what appears to be a rendering issue with the buffer font size at 16 for the letter "f". You can see in the screenshots that the top portion of the letter is fine at 15 and 17, but partially cut off at 16. Sadly, this is the font size I use. 😿 Update: 15.999 works just fine (as does 16.001...anything that is not exactly 16). Guess I'll go with that. |
Not gonna lie, the IBM fonts suck for code editing. I've tried them on many different editors, and I've never been happy with them. The Zed fonts are THE BEST THAT I'VE SEEN for code editing, they're ridiculously easy on my eyes, and for someone who sits at his computer for the bigger part of the day - it's a big benefit to not over-stress your eyes with hard to read fonts. It would be amazing if the zed fonts were brought back into zed as the default fonts, I don't see much of a downside to them being included. I'm surprised this even got merged, as this doesn't really make too much sense. |
For those who don't like the new font, https://www.jetbrains.com/lp/mono/ is the closest one to the old one, which seems a much better option. |
i agree, it was easily the best code editor font ive ever seen as well in all my programming years. it's sad to see it so unceremoniously removed. ive made a new issue request asking it to have a new install |
for those (like myself) who can’t handle IBM Plex, Adobe’s Source Code Pro font family is highly readable and very well-crafted (for homebrew users: however, i’ve actually switched over to Apple’s SF Mono, which is extremely readable, with a slightly taller x-height, a single-storey in fact, as @heiskr suggests, i think this change would’ve made more sense if it went from the custom Zed fonts to the OS defaults, rather than one custom font to another custom font with a smaller file size, but that ship has sailed. |
for all who are curious: "The WidthClass is set to 400 instead of 300, which breaks cosmic texts fallback stack on Linux. (Also they're really big, for some reason I don't know yet)" #15053 (comment) #13596 (comment) if anyone knows how to fix that, thatd be great. |
upstream moved to using flex-mono and plex-sans instead of maintaining their own custom fonts. For more info see: zed-industries/zed#13596
all of you asked why this was done, the above comment cites the reason in a different discussion (as well as another dev saying virtually the same thing). tl;dr: they configured it wrong and the size was too big for some reason so theyd thought it'd be easier to abandon it and take a new font than fix its issues. if anyone knows how to fix those issues, start a PR and hope this issue gets worked on for easy installs |
There is an example in the docs of how to make comments use italics: |
This is only for |
Release Notes: