Improve styling for diff hunks #21145
Open
+3
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the background of the created and deleted diff hunks to use the
created_background
anddeleted_background
styles, respectively, and it makes the folded indicator for deleted hunks much more visible. Without this, the backgrounds just use a faded version of the foregrounds, which can make it hard to design themes where the gutter marker is sufficiently bright or saturated and the background is sufficiently dark or unsaturated.Here are some screenshots with a few different themes. Old is on the left, new is on the right.
Andromeda:
Summercamp:
Rosé Pine Dawn:
Release Notes:
created_background
anddeleted_background
colors from the theme.