-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add word count for markdown files #21263
base: main
Are you sure you want to change the base?
Add word count for markdown files #21263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be wrong, but...
.text_for_range(selection.start..selection.end) | ||
.map(|t| t.split_whitespace().count()) | ||
.sum::<usize>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my understanding, this snippet will count the exact words in the markdown file, and not the real amount of words rendered by it.
This may include the markup tags, which might be undesirable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, t.split_whitespace()
will count markdown elements as words, etc and give a rough word count when markdown elements are involved. On the other hand, I don't think getting the exact word count for markdown files is feasible without some convoluted logic.
If the repo maintainers think the word count needs to be more accurate, I can modify the PR (Off the top of my head, I am thinking I just have to sanitise the text before counting the words)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some way to get the text preview that zed generates and count words in that, if that is performant enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting the text that ends up actually being rendered might be possible with tree-sitter queries?
@saahityaedams : The number of words seems different, I have tried different online services for each the number of words seems different. |
Release Notes: