Force code actions to be single line #21409
Open
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses zed-industries#21403 partially. Is consistent with VSCode behaviour
cla-bot
bot
added
the
cla-signed
osiewicz
reviewed
Dec 2, 2024
| @@ -1707,7 +1709,7 @@ impl CodeActionsMenu { | |||
| } | |||
| }), | |||
| ) | |||
| .child(SharedString::from(task.resolved_label.clone())) | |||
| .child(SharedString::from(task.resolved_label.replace("\n", ""))) | |||
There was a problem hiding this comment.
I'm pretty sure we have a single_line helper on Label, if you'd like to use that.
There was a problem hiding this comment.
It replaces \n with  which looks weird. I'd rather prefer nothing or a space, not sure which is better
danilo-leal
added a commit
that referenced
this pull request
Dec 3, 2024
Closes #20678 | Before | After | | --- | --- | | <img width="672" alt="SCR-20241203-jreb" src="https://github.com/user-attachments/assets/411ba2a6-712f-4ab7-a320-12ac9a35c1e1"> | <img width="771" alt="SCR-20241203-jwhe" src="https://github.com/user-attachments/assets/022c8ee9-4089-4c09-aa4b-12a0f5528822"> | Release Notes: - Fixed AI Context menu text wrapping causing overlap. Also cc #21409 @WeetHet @osiewicz to use `Label`, this PR has been fixed `Label` to ensure `whitespace_nowrap` when use `single_line`. --------- Co-authored-by: Danilo Leal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #21403 partially. Is consistent with the behaviour in VSCode
Before:
After:
Release Notes: