workspace::Open: Fix trapped cursor/selection on update
#25402
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
|
Thanks! We should only do this if the index no longer exists, otherwise it'll keep jumping to the top. |
|
@ConradIrwin, just to double check, is this behavior not wanted? -- it looks like it matches the file finder File finder: (Reset on every update) Screen.Recording.2025-02-22.at.6.36.26.PM.movFile open: Screen.Recording.2025-02-22.at.6.36.06.PM.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #ISSUE
Issue: Selection index does not reset when the matches update, which can lead to the selection getting trapped when that index does not exist in the next matches.
Screen.Recording.2025-02-22.at.12.45.02.PM.mov
This is in workspace::Open with "use_system_path_prompts": false
Release Notes: