workspace: Add trailing / to directories on completion when using OpenPathPrompt
#25430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
|
Nice! |
JunkuiZhang
force-pushed
the
path-prompt
branch
from
fcc9f90 to
0840b76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25045
With the setting
"use_system_path_prompts": false, previously, if the completion target was a directory, no separator would be added after it, requiring us to manually append a/or\. Now, if the completion target is a directory, a/or\will be automatically added. On Windows, both/and\are considered valid path separators.2025-02-24.000004.mp4
Release Notes: