Name collider fields for "effects" / misc. #1925
Draft
+1,072
−1,057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dragorn421
changed the title
Dragorn421
commented
Mar 16, 2024
There was a problem hiding this comment.
The interesting review bits among all the CtrL+Shift+H noise are:
include/z64actor.hinclude/z64collision_check.hCollisionCheck_SetATvsACinsrc/code/z_collision_check.cfor theplayer[AT|AC]HitReactionlogicsCylinderInitinz_obj_bombiwa.c, andsQuadInit,sCylinderInitinz_en_vali.c, as demonstration forPLAYER_[AC|AT]_HIT_REACTION_usage (which aren't used in all collider init data everywhere right now)z_player.cwith the only uses ofplayer[AT|AC]HitReaction
Dragorn421
force-pushed
the
colliders_effectsfields
branch
from
8c6a8e3
to
65b4c9b
Compare
fig02
approved these changes
Aug 11, 2024
|
due to bss memes this PR conflicts with anything merged to main, I'm not bothering to merge every time but the PR can still be reviewed anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Natural continuation to collider cleanup ( #1427 #1637 ), and some names based on feedback deriving from #1601 (comment)
Names are Best I Could Think Of ™️ , comments and discussion is, as per usual, very welcome!
Collider.colType/COLTYPE_->Collider.colMaterial/COL_MATERIAL_ColliderElement.elemType/ELEMTYPE_->ColliderElement.elemMaterial/ELEM_MATERIAL_CollisionCheckInfo.[at|ac]HitEffect->CollisionCheckInfo.player[AT|AC]HitReactionColliderElementDamageInfoAT.effecttoColliderElementDamageInfoAT.playerACHitReactionand similar with dmgInfoAC/playerATPLAYER_AT_HIT_,PLAYER_AC_HIT_enums for these fields' valuesAC-named constant in "AT" data which is very confusing, but I don't have a better idea at presentColliderElementDamageInfo[AT|AC].dmgFlagsnorCollisionCheckInfo.damageEffect(in contrary to some prior discussion) (because no idea)