Document "Normal" Skybox #1955
Document "Normal" Skybox #1955
Conversation
include/z64environment.h
Outdated
| SKYBOX_INDEX_HOLY_RESERVED_10, | ||
| SKYBOX_INDEX_HOLY_RESERVED_11, | ||
| // Error checking | ||
| SKYBOX_INDEX_INIT_MAGIC = 99, // Magic number used to detect a fault during initialization, value unused. |
There was a problem hiding this comment.
nit: IMO SKYBOX_INDEX_INIT_MAGIC -> SKYBOX_INDEX_INIT ("magic" makes me think of in-game magic, and really aren't all enum values magic numbers?)
There was a problem hiding this comment.
For me what makes it magic is that the assigned value of 99 is set but never used by the program; it'd only show up when looking at a memory viewer.
include/z64skybox.h
Outdated
| @@ -66,6 +66,10 @@ typedef struct { | |||
|
|
|||
| extern SkyboxFile gNormalSkyFiles[]; | |||
|
|
|||
| // Tests if the skybox palette for the given skybox should be written to color index 0-127. | |||
| // If false, it should be written to color index 128-255 | |||
| #define IS_NORMAL_SKY_PALETTE_ALLOC_FRONT(skyboxIndex) ((skyboxIndex & 1) ^ ((skyboxIndex & 4) >> 2)) | |||
There was a problem hiding this comment.
the name IS_NORMAL_SKY_PALETTE_ALLOC_FRONT is mostly gibberish to me tbh but I don't really have any better ideas
There was a problem hiding this comment.
Perhaps it should be something more direct, like IS_NORMAL_SKYBOX_COLOR_INDEX_0/IS_NORMAL_SKYBOX_IMAGE_COLOR_INDEX_0?
|
Contributions made in this pr are licensed under CC0 |
| typedef enum { | ||
| // Clear Sky | ||
| SKYBOX_INDEX_CLEAR_SUNRISE, | ||
| SKYBOX_INDEX_CLEAR_DAY, | ||
| SKYBOX_INDEX_CLEAR_SUNSET, | ||
| SKYBOX_INDEX_CLEAR_NIGHT, | ||
| // Cloudy Sky | ||
| SKYBOX_INDEX_CLOUDY_SUNRISE, | ||
| SKYBOX_INDEX_CLOUDY_DAY, | ||
| SKYBOX_INDEX_CLOUDY_SUNSET, | ||
| SKYBOX_INDEX_CLOUDY_NIGHT, |
There was a problem hiding this comment.
Wondering if we have a better descriptor than just "index" for this concept in general. Ill take a closer look at this and try to think about it more, but it makes reading all of the code pretty clunky to me.
Dont think "type" works cause this isnt necessarily the skybox type. But looking for something along those lines
No description provided.