More descriptive names for CS_BEGIN_CUTSCENE and CS_END #2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fig02
reviewed
Nov 30, 2024
cadmic
reviewed
Nov 30, 2024
fig02
approved these changes
Dec 1, 2024
cadmic
approved these changes
Dec 1, 2024
mzxrules
reviewed
Dec 1, 2024
Co-authored-by: mzxrules <[email protected]>
fig02
reviewed
Dec 1, 2024
subrepo: subdir: "tools/ZAPD" merged: "c04562d30" upstream: origin: "https://github.com/zeldaret/ZAPD.git" branch: "master" commit: "c04562d30" git-subrepo: version: "0.4.9" origin: "https://github.com/ingydotnet/git-subrepo.git" commit: "cce3d93"
|
Opened a PR to your branch that updates ZAPD using |
git subrepo pull --force tools/ZAPD
fig02
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion with Fig and cadmic, change
CS_BEGIN_CUTSCENEandCS_ENDmacros toCS_HEADERandCS_END_SCRIPT, respectively. Previous names could be misinterpreted as controlling cutscene behavior when they are only used internally by the cutscene script parser.Also changes the check in
Cutscene_ProcessScriptforCS_CMD_END_OF_SCRIPTto reference the correct name.