Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MM decomp names for some unnamed code files #2312

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

cadmic
Copy link
Contributor

@cadmic cadmic commented Dec 1, 2024

I'm going on a crusade to name all the code_80XXXXXX.c files because I have a lot of trouble telling them apart. The files in this PR are named in MM decomp already, so while the names aren't be perfect I think it's a good starting point.

code_800430A0.c => z_bg_collect.c
code_80043480.c => z_bg_item.c
code_8006C3A0.c => z_env_flags.c
code_80097A00.c => z_inventory.c
code_800FC620.c => system_heap.c

Copy link
Collaborator

@Pepe20129 Pepe20129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although it seems that z_inventory was probably originally called z_save and z_env_flags was probably something like z_f_env due to the ordering.

@cadmic
Copy link
Contributor Author

cadmic commented Dec 8, 2024

yeah I agree, and personally I would like to names these closer to what we think the original names are, but it seems like the precedent is to not care about that (e.g. z_rumble vs z_vibrate)

@fig02
Copy link
Collaborator

fig02 commented Dec 8, 2024

One day when the "original filename" section exists on every file, we can add our speculations of what original filenames might have been.

@fig02 fig02 merged commit 06ceb8e into zeldaret:main Dec 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants