Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split code_800D31A0.c into sys_freeze.c and sys_debug_controller.c #2315

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

cadmic
Copy link
Contributor

@cadmic cadmic commented Dec 1, 2024

I kinda think these are two separate files since half of it is debug-only, and it's not that related to the other half.

@hensldm
Copy link
Contributor

hensldm commented Dec 1, 2024

Out of curiosity any thoughts on the name for func_800D31A0. I was thinking something like just Freeze or Freeze_Forever? For reference we have an open PR in MM to rename the file and function (though I agree with sys_freeze for the file name vs the sleep_forever in that PR).

@cadmic
Copy link
Contributor Author

cadmic commented Dec 1, 2024

Oh, I didn't think to check open MM PRs, thanks. IMO Freeze_Forever sounds redundant, so if Freeze is not specific enough then maybe we can say what is being frozen (something like FreezeCpu?)

@fig02 fig02 merged commit d886e76 into zeldaret:main Dec 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants