-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name asset extraction tools more consistently #2316
base: main
Are you sure you want to change the base?
Conversation
For the text, I like doing something similar to audio. Have the two scripts in a folder called text, than create an extract_text.py outside it that parses the config for what the text extract script needs, and calls msgdis's main function (in zeldaret/mm#1750 I renamed it to extract). |
hm, I think that could make sense if the main function was identical to MM's like with the audio tools. Otherwise, I think the extra indirection is not worth it. Either way, could we consider that out-of-scope for this PR? |
The main function in msgdis.py should be the same. |
hm, I tried a simple
Why's that? I don't think an extra commit would cost that much |
are you concerned about losing history due to git shenanigans if we rename it later and aren't careful? |
Think you are outdated. Updated version should just have
More so personal preference of keeping the git history cleaner. |
Ah yeah, my bad. It still seems like a bit of work to factor out all of the differences though
I'm also a fan of a clean git history, although my idea of that is:
Number 3 there is often at odds with minimizing the total number of commits. For example, I think this change would be better as "name asset extraction tools more consistently" instead of "name asset extraction tools more consistently, and also prepare for unifying OOT and MM text extraction". (As an aside, in the same vein I much prefer a bunch of 1-line commits rather than "Misc Cleanup", since mixing changes together like that makes it harder to read the history.) |
Now they're all run as
$(PYTHON) tools/extract_foo.py
.