Fix crashes in status-bar plugin #1956
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng from the cache. Make writing the cache an atomic operation, to avoid clobbering seen when running multiple instances of zellij
jaeheonji
reviewed
Dec 20, 2022
| file.write_all(json_cache.as_bytes()) | ||
| .map_err(LocalCacheError::Io)?; | ||
| file.persist(self.path.as_path()) |
There was a problem hiding this comment.
Hi @rdeaton, Thank you for contributing!
When I run your code in my environment, I keep getting the following error.
DEBUG |/home/meow/Projects/zelli| 2022-12-20 21:27:49.223 [id: 1 ] Error flushing local cache to disk: Persist(PersistError { error: Os { code: 20, kind: AlreadyExists, message: "File exists" }, file: NamedTempFile("/tmp/.tmpKk1Sqm") })
Could you check re-again?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turned a number of panics into logged errors that otherwise continue when interacting with the status-bar plugin's tips cache, and made writes to the cache atomic to avoid clobbering seen when running multiple zellij instances.
Fixes #1944