Add documentation to crates #2599
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zykino
reviewed
Jul 1, 2023
There was a problem hiding this comment.
I’m not a Zellij maintainer, but seeing the typo I went ahead and did my comments.
For you interrogation (and based on deduction of what I understand about zellij):
I think the server is like a daemon : running in the background keeping sessions alive.
A client should be the part living in the terminal that connect to the server. So the part that do the actual printing to screen and getting keybindings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of trying to familiarize myself with the project, I'd thought it would be good to start to make the crates more digestible.
There are no readmes for client and server, mainly because I don't understand what they are. Could use some help describing what they do and what they contain.