Skip to content

Conversation

maass-hamburg
Copy link
Member

remove phy init and config from the legacy ethernet hal,
as that is already done in zephyr before and we don't want it to
be overwritten

remove phy init and config as that is already
done in zephyr before and we don't want it to
be overwritten

Signed-off-by: Fin Maaß <[email protected]>
remove phy init and config as that is already
done in zephyr before and we don't want it to
be overwritten

Signed-off-by: Fin Maaß <[email protected]>
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 options coming to HAL usage. Either using it untouched, either not using it. I'm not keen on opening the door to this kind of modification.

@maass-hamburg
Copy link
Member Author

unfortunately ETH_MACDMAConfig is a static function and not exposed, so would also have to copy that over to zephyr, that would not only be ugly but also have some copyright problems, as the hal is not under the Apache 2.0 Licence or any other OSS license. If that is the only option I would leave that for somebody else to do and close this and the PR in zephyr related to this.

There are already other patches in the hal and this one would be pretty easy to reapply, as it is just removing a big block from one function.

@erwango
Copy link
Member

erwango commented Aug 21, 2025

unfortunately ETH_MACDMAConfig is a static function and not exposed, so would also have to copy that over to zephyr, that would not only be ugly but also have some copyright problems, as the hal is not under the Apache 2.0 Licence or any other OSS license. If that is the only option I would leave that for somebody else to do and close this and the PR in zephyr related to this.

There are already other patches in the hal and this one would be pretty easy to reapply, as it is just removing a big block from one function.

I'll take some time to think about it and specially how to do it while not opening a can of worms by letting think anyone can patch HAL whenever this is the easiest solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants