hw_if: hal: Add watchdog interrupt stats #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krish2718
reviewed
Nov 26, 2024
kapbh
force-pushed
the
recovery_stats
branch
from
aec7b0b
to
f928c46
Compare
sachinthegreen
requested changes
Nov 26, 2024
hw_if/hal/inc/hal_structs.h
Outdated
| @@ -252,6 +252,10 @@ struct nrf_wifi_hal_dev_ctx { | |||
| unsigned long last_wakeup_now_deasserted_time_ms; | |||
| /** RPU sleep opp time */ | |||
| unsigned long last_rpu_sleep_opp_time_ms; | |||
| /** Recieved watchdog timer interrupt */ | |||
There was a problem hiding this comment.
Suggested change
| /** Recieved watchdog timer interrupt */ | |
| /** Number of watchdog timer interrupts received */ |
hw_if/hal/inc/hal_structs.h
Outdated
| @@ -252,6 +252,10 @@ struct nrf_wifi_hal_dev_ctx { | |||
| unsigned long last_wakeup_now_deasserted_time_ms; | |||
| /** RPU sleep opp time */ | |||
| unsigned long last_rpu_sleep_opp_time_ms; | |||
| /** Recieved watchdog timer interrupt */ | |||
| int watchdog_timer_recieved; | |||
There was a problem hiding this comment.
Suggested change
| int watchdog_timer_recieved; | |
| int watchdog_timer_received; |
There was a problem hiding this comment.
Instead of wdt_irq_received, watchdog_timer_received is better right?
hw_if/hal/inc/hal_structs.h
Outdated
| @@ -252,6 +252,10 @@ struct nrf_wifi_hal_dev_ctx { | |||
| unsigned long last_wakeup_now_deasserted_time_ms; | |||
| /** RPU sleep opp time */ | |||
| unsigned long last_rpu_sleep_opp_time_ms; | |||
| /** Recieved watchdog timer interrupt */ | |||
| int wdt_irq_recieved; | |||
| /** Ignored watchdog timer interrupt */ | |||
There was a problem hiding this comment.
Suggested change
| /** Ignored watchdog timer interrupt */ | |
| /** Number of watchdog timer interrupts ignored */ |
hw_if/hal/inc/hal_structs.h
Outdated
| @@ -252,6 +252,10 @@ struct nrf_wifi_hal_dev_ctx { | |||
| unsigned long last_wakeup_now_deasserted_time_ms; | |||
| /** RPU sleep opp time */ | |||
| unsigned long last_rpu_sleep_opp_time_ms; | |||
| /** Recieved watchdog timer interrupt */ | |||
| int wdt_irq_recieved; | |||
There was a problem hiding this comment.
Suggested change
| int wdt_irq_recieved; | |
| int wdt_irq_received; |
| @@ -521,6 +521,7 @@ static enum nrf_wifi_status hal_rpu_process_wdog(struct nrf_wifi_hal_dev_ctx *ha | |||
| * PS_ACTIVE state for more than the timeout period | |||
| */ | |||
| if (!is_rpu_recovery_needed(hal_dev_ctx)) { | |||
| hal_dev_ctx->wdt_irq_ignored++; | |||
There was a problem hiding this comment.
Shouldn't this also be protected with NRF_WIFI_RPU_RECOVERY_DEBUG ?
There was a problem hiding this comment.
It's already in NRF_WIFI_RPU_RECOVERY.
| @@ -577,6 +578,7 @@ enum nrf_wifi_status hal_rpu_irq_process(struct nrf_wifi_hal_dev_ctx *hal_dev_ct | |||
| num_events = hal_rpu_event_get_all(hal_dev_ctx); | |||
|
|
|||
| if (hal_rpu_irq_wdog_chk(hal_dev_ctx)) { | |||
| hal_dev_ctx->wdt_irq_recieved++; | |||
| nrf_wifi_osal_log_dbg("Received watchdog interrupt"); | |||
There was a problem hiding this comment.
Shouldn't both statements above also be protected with NRF_WIFI_RPU_RECOVERY_DEBUG ?
There was a problem hiding this comment.
It should be with NRF_WIFI_RPU_RECOVERY.
Add watchdog interrupt stats for number of time interrupt received and ignored. Signed-off-by: Kapil Bhatt <[email protected]>
kapbh
force-pushed
the
recovery_stats
branch
from
f928c46
to
89a7619
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add watchdog interrupt stats for number of time
interrupt received and ignored.