[POC] dts: bindings: comparator: nordic: Change ext analog inputs type to int #95106
+216
−250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaz1-nordic
requested review from
masz-nordic,
bjarki-andreasen and
magp-nordic
zephyrbot
added
area: Samples
zephyrbot
requested review from
anangl,
dbaluta,
decsny,
dleach02,
JarmouniA,
kartben,
kl-cruz,
manuargue,
mmahadevan108,
nashif and
nika-nordic
jaz1-nordic
force-pushed
the
nrfx-7710_unify_aanalog_pins_defs
branch
2 times, most recently
from
3355002 to
a4e2fb4
Compare
Unify external analog inputs type to be consistent in COMP, LPCOMP and SAADC nordic drivers. Signed-off-by: Jakub Zymelka <[email protected]>
jaz1-nordic
force-pushed
the
nrfx-7710_unify_aanalog_pins_defs
branch
from
a4e2fb4 to
f9b434d
Compare
External analog input types changed from `string` to `int`. Signed-off-by: Jakub Zymelka <[email protected]>
Align samples and tests boards overlays for changed comparator input types. Signed-off-by: Jakub Zymelka <[email protected]>
jaz1-nordic
force-pushed
the
nrfx-7710_unify_aanalog_pins_defs
branch
from
f9b434d to
826d9d1
Compare
|
|
if this gets approved, will need to update migration guide |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify external analog inputs type to be consistent in COMP, LPCOMP and SAADC nordic drivers.