Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when exceptSelector is defined and e.target is empty an error is thrown from closest function #266

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

Scra3
Copy link
Contributor

@Scra3 Scra3 commented Sep 30, 2024

Hello,
Thank you very much for your lib :)
We encounter an error in production, is it possible to merge our contribution to fix the issue.
Indeed when exceptSelector is defined and an event without target is emitted the closest function throws an error.

@Scra3 Scra3 changed the title fix: when exceptSelector is set and e.target is empty fix: when exceptSelector is set and e.target is empty an error is thrown from closest function Sep 30, 2024
@Scra3 Scra3 changed the title fix: when exceptSelector is set and e.target is empty an error is thrown from closest function fix: when exceptSelector is defined and e.target is empty an error is thrown from closest function Sep 30, 2024
@zeppelin
Copy link
Owner

zeppelin commented Oct 2, 2024

@Scra3 Thank you! I haven't encountered to this yet, but will definitely merge & release if your app fails on this

Co-authored-by: Gabor Babicz <[email protected]>
@Scra3
Copy link
Contributor Author

Scra3 commented Oct 2, 2024

@zeppelin Thank you for your time :) I have applied your suggestion.

@Scra3
Copy link
Contributor Author

Scra3 commented Oct 2, 2024

How can I fix the CI 🙏 ? I think the error is not related to my change :/

Error: The API deprecated by template-action was removed in ember-source 6.0.0. The message was: Usage of the `{{action}}` modifier is deprecated. Migrate to native functions and function invocation.. Please see https://deprecations.emberjs.com/id/template-action for more details.
                at deprecateUntil (http://localhost:7357/assets/vendor.js:1659:14[89](https://github.com/zeppelin/ember-click-outside/actions/runs/11142109949/job/30965175897?pr=266#step:6:90))
                at ActionModifierManager.install (http://localhost:7357/assets/vendor.js:10635:252)
                at http://localhost:7357/assets/vendor.js:6847:2567
                at track (http://localhost:7357/assets/vendor.js:1799:327)
                at TransactionImpl.commit (http://localhost:7357/assets/vendor.js:6847:2549)
                at EnvironmentImpl.commit (http://localhost:7357/assets/vendor.js:6848:1970)
                at inTransaction (http://localhost:7357/assets/vendor.js:6848:2349)
                at Renderer._renderRoots (http://localhost:7357/assets/vendor.js:14738:1060)
                at Renderer._renderRootsTransaction (http://localhost:7357/assets/vendor.js:14750:73)
                at Renderer._revalidate (http://localhost:7357/assets/vendor.js:14752:268)
        message: >
            global failure: Error: The API deprecated by template-action was removed in ember-source 6.0.0. The message was: Usage of the `{{action}}` modifier is deprecated. Migrate to native functions and function invocation.. Please see

@zeppelin zeppelin merged commit c163597 into zeppelin:master Oct 3, 2024
10 of 12 checks passed
@zeppelin zeppelin added the bug label Oct 3, 2024
@zeppelin
Copy link
Owner

zeppelin commented Oct 4, 2024

@Scra3 Later I noticed the release script didn't run, I'll look into the issue later today

@zeppelin
Copy link
Owner

zeppelin commented Oct 5, 2024

Released as 6.1.1, sorry for the mess. Thanks again for taking time to fix this!

@Scra3
Copy link
Contributor Author

Scra3 commented Oct 7, 2024

Hello,
Nice 🥳
Thanks again for your work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants