fix: issue #3840

zeromicro · Jan 14, 2024 · 36399f6 · 36399f6
1 parent 408827d
commit 36399f6
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 13 deletions.
diff --git a/core/mapping/unmarshaler.go b/core/mapping/unmarshaler.go
@@ -626,11 +626,11 @@ func (u *Unmarshaler) processFieldPrimitiveWithJSONNumber(fieldType reflect.Type
 		}
 
 		// if value is a pointer, we need to check overflow with the pointer's value.
-		overflowValidator := value
-		if overflowValidator.Type().Kind() == reflect.Ptr {
-			overflowValidator = overflowValidator.Elem()
+		derefedValue := value
+		for derefedValue.Type().Kind() == reflect.Ptr {
+			derefedValue = derefedValue.Elem()
 		}
-		if overflowValidator.OverflowFloat(fValue) {
+		if derefedValue.CanFloat() && derefedValue.OverflowFloat(fValue) {
 			return fmt.Errorf("parsing %q as float32: value out of range", v.String())
 		}
 

diff --git a/core/mapping/unmarshaler_test.go b/core/mapping/unmarshaler_test.go
@@ -1343,16 +1343,31 @@ func TestUnmarshalNullableSlice(t *testing.T) {
 }
 
 func TestUnmarshalWithFloatPtr(t *testing.T) {
-	var v struct {
-		WeightFloat32 *float32 `key:"weightFloat32,optional"`
-	}
-	m := map[string]any{
-		"weightFloat32": json.Number("3.2"),
-	}
+	t.Run("*float32", func(t *testing.T) {
+		var v struct {
+			WeightFloat32 *float32 `key:"weightFloat32,optional"`
+		}
+		m := map[string]any{
+			"weightFloat32": json.Number("3.2"),
+		}
 
-	if assert.NoError(t, UnmarshalKey(m, &v)) {
-		assert.Equal(t, float32(3.2), *v.WeightFloat32)
-	}
+		if assert.NoError(t, UnmarshalKey(m, &v)) {
+			assert.Equal(t, float32(3.2), *v.WeightFloat32)
+		}
+	})
+
+	t.Run("**float32", func(t *testing.T) {
+		var v struct {
+			WeightFloat32 **float32 `key:"weightFloat32,optional"`
+		}
+		m := map[string]any{
+			"weightFloat32": json.Number("3.2"),
+		}
+
+		if assert.NoError(t, UnmarshalKey(m, &v)) {
+			assert.Equal(t, float32(3.2), **v.WeightFloat32)
+		}
+	})
 }
 
 func TestUnmarshalIntSlice(t *testing.T) {