Skip to content

Commit

Permalink
feat: support build tag to reduce binary size w/o k8s (#4323)
Browse files Browse the repository at this point in the history
  • Loading branch information
kevwan authored Aug 20, 2024
1 parent e220d3a commit 9d9c7e0
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 4 deletions.
2 changes: 2 additions & 0 deletions zrpc/resolver/internal/kubebuilder.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
//go:build !no_k8s

package internal

import (
Expand Down
8 changes: 8 additions & 0 deletions zrpc/resolver/internal/register.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
//go:build no_k8s

package internal

// RegisterResolver registers the direct, etcd and discov schemes to the resolver.
func RegisterResolver() {
register()
}
13 changes: 13 additions & 0 deletions zrpc/resolver/internal/register_k8s.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
//go:build !no_k8s

package internal

import "google.golang.org/grpc/resolver"

var k8sResolverBuilder kubeBuilder

// RegisterResolver registers the direct, etcd, discov and k8s schemes to the resolver.
func RegisterResolver() {
register()
resolver.Register(&k8sResolverBuilder)
}
5 changes: 1 addition & 4 deletions zrpc/resolver/internal/resolver.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,12 @@ var (
directResolverBuilder directBuilder
discovResolverBuilder discovBuilder
etcdResolverBuilder etcdBuilder
k8sResolverBuilder kubeBuilder
)

// RegisterResolver registers the direct and discov schemes to the resolver.
func RegisterResolver() {
func register() {
resolver.Register(&directResolverBuilder)
resolver.Register(&discovResolverBuilder)
resolver.Register(&etcdResolverBuilder)
resolver.Register(&k8sResolverBuilder)
}

type nopResolver struct {
Expand Down

0 comments on commit 9d9c7e0

Please sign in to comment.