Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor zrpc server interceptor builder #4300

Merged
merged 5 commits into from
Aug 8, 2024
Merged

Conversation

zcong1993
Copy link
Member

@zcong1993 zcong1993 commented Aug 6, 2024

To build zrpc server interceptor in one place, so we can tweak the order easily. And this PR not change any order of server interceptors.

@zcong1993 zcong1993 self-assigned this Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.10%. Comparing base (8690859) to head (c16e42f).
Report is 119 commits behind head on master.

Files Patch % Lines
zrpc/server.go 96.15% 0 Missing and 1 partial ⚠️
Additional details and impacted files
Files Coverage Δ
zrpc/internal/rpcpubserver.go 76.47% <100.00%> (+1.47%) ⬆️
zrpc/internal/rpcserver.go 100.00% <100.00%> (ø)
zrpc/internal/server.go 100.00% <ø> (ø)
zrpc/server.go 90.24% <96.15%> (+5.43%) ⬆️

... and 251 files with indirect coverage changes

@zcong1993 zcong1993 changed the title WIP: refactor zrpc server interceptor builder refactor zrpc server interceptor builder Aug 8, 2024
@zcong1993 zcong1993 requested a review from kevwan August 8, 2024 03:53
@kevwan kevwan added this pull request to the merge queue Aug 8, 2024
Merged via the queue into zeromicro:master with commit 03756c9 Aug 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants