Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: not using goproxy by default #4613

Merged
merged 1 commit into from
Jan 29, 2025
Merged

chore: not using goproxy by default #4613

merged 1 commit into from
Jan 29, 2025

Conversation

kevwan
Copy link
Contributor

@kevwan kevwan commented Jan 29, 2025

  1. no goproxy by default, if need goproxy, it should be set with go env, not by goctl
  2. remove aliyun docker registry, because it doesn't work

@codecov Codecov
Copy link

codecov bot commented Jan 29, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.57%. Comparing base (8690859) to head (de05e57).
Report is 242 commits behind head on master.

Additional details and impacted files

see 8 files with indirect coverage changes

@kevwan kevwan force-pushed the chore/no-goproxy-by-default branch from 069a6ec to de05e57 Compare January 29, 2025 04:00
@kevwan kevwan merged commit f669d84 into zeromicro:master Jan 29, 2025
6 checks passed
@kevwan kevwan deleted the chore/no-goproxy-by-default branch January 29, 2025 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kevwan