Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve profile design #323

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

NaitYoussef
Copy link
Collaborator

No description provided.

@zeroual zeroual temporarily deployed to otchi-pr-323 August 1, 2017 07:53 Inactive
@zeroual
Copy link
Owner

zeroual commented Aug 1, 2017

good work @NaitYoussef
I think if we can improve card margins and border size will be better
capture

@NaitYoussef
Copy link
Collaborator Author

NaitYoussef commented Aug 1, 2017

@zeroual Yes that's right ! And the mobile version is no good neither :'(, Ill fix it 🔢

@zeroual
Copy link
Owner

zeroual commented Aug 2, 2017

@NaitYoussef be aware when you rebase with master after mergin @qasmi pull request .
You will risk to have some conflicts 😂

@NaitYoussef
Copy link
Collaborator Author

Ok @zeroual XD, thanks

@zeroual
Copy link
Owner

zeroual commented Aug 2, 2017

lool , and i f you can improve the display of nb visits , we will appreciate that 😂
image

@NaitYoussef NaitYoussef temporarily deployed to otchi-pr-323 August 7, 2017 08:39 Inactive
@NaitYoussef NaitYoussef temporarily deployed to otchi-pr-323 August 7, 2017 14:11 Inactive
@zeroual
Copy link
Owner

zeroual commented Aug 7, 2017

good job @NaitYoussef . you fixed all things

try to change the border of .card .profile-header-background
border-bottom: 1px solid rgba(0,0,0,.15)!important;
i find the actual border is big

@zeroual
Copy link
Owner

zeroual commented Aug 7, 2017

capture

<div class="panel panel-default">
<div class="panel-body">
<div class="row profile-header-background"style="margin-top:-20px;">
<div class="panel-body profile-header-panel" >
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can move style="margin-top:-20px;" to .profile-header-background in css file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I still have to clean my code, for now I'm just trying to get some feedback !

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you try to change the border size ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I did

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you're right I like it more now 👍

@zeroual
Copy link
Owner

zeroual commented Aug 8, 2017

@NaitYoussef i want to merge your PR but is not updated with master.
can you squash and rebase with master

@zeroual
Copy link
Owner

zeroual commented Aug 8, 2017

and i think that you are fogot to display the visits count in profil 💯 (what @qasmi did last week )

@NaitYoussef
Copy link
Collaborator Author

Okay sir will rebase it today 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants