-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve profile design #323
base: master
Are you sure you want to change the base?
Conversation
good work @NaitYoussef |
@zeroual Yes that's right ! And the mobile version is no good neither :'(, Ill fix it 🔢 |
@NaitYoussef be aware when you rebase with master after mergin @qasmi pull request . |
Ok @zeroual XD, thanks |
good job @NaitYoussef . you fixed all things try to change the border of .card .profile-header-background |
<div class="panel panel-default"> | ||
<div class="panel-body"> | ||
<div class="row profile-header-background"style="margin-top:-20px;"> | ||
<div class="panel-body profile-header-panel" > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can move style="margin-top:-20px;"
to .profile-header-background in css file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I still have to clean my code, for now I'm just trying to get some feedback !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you try to change the border size ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I did
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you're right I like it more now 👍
@NaitYoussef i want to merge your PR but is not updated with master. |
and i think that you are fogot to display the visits count in profil 💯 (what @qasmi did last week ) |
Okay sir will rebase it today 😉 |
No description provided.