Add typescript definitions #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to allow installing with yarn
…the cmdCred script
|
your CI config needs a touch... checking node 4 is a little outdated I would say, your tests run fine locally |
added 3 commits
December 6, 2017 10:50
…to Cox-Automotive-master # Conflicts: # lib/run-powershell.js # src/run-powershell.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a simple typedef of your great lib.
allows to use in typescript environment.
if you want me to rebase I can do, I did all these commits on the online github editor ;-) and then cloned my fork...
you can also merge with squash to get one commit into your history
i've also added a commit to relax node engine constrain since it gave me trouble when installing with Yarn
tag version 1.3,0
I've now also added a fix for when this is installed globally on windows and the global npm packages are within \program files\npm... (for instance -really anything with a space) the powershell script would not run as the path was not quoted and it would try only to run the part with the c:\program ....
tag 1.3.1
since I need this... I added the commits made by @brianantonelli (Cox-Automotive ) and tagged now with
tag 1.3..2