This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
#166 - Populate admin with users #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msvrtan
previously requested changes
Jan 10, 2018
src/Entity/User.php
Outdated
| * | ||
| * Flags this user as admin (adds ROLE_SUPER_ADMIN) | ||
| */ | ||
| public $administrator; |
There was a problem hiding this comment.
not sure putting this as public is a good idea, I think easy admin will skip the getters/setters
There was a problem hiding this comment.
right you are; forgot to change this while testing things out.
HcsOmot
force-pushed
the
166-populate-admin-with-users
branch
from
1e87df0
to
b28d380
Compare
EasyAdmin backend can now keep track of registered users, and can modify their roles. Closes zgphp#166
HcsOmot
force-pushed
the
166-populate-admin-with-users
branch
from
b28d380
to
792e308
Compare
|
hey @msvrtan, I've removed unnecessary commits, so you can do the review more easily. Sorry about the mess. Regarding the tests - I'm working on it. Your call if you want to merge this as is, or wait for another commit with tests. |
|
damn. still no tests. we're way behind on this. i hope i'll make some progress during the next week. |
msvrtan
approved these changes
Mar 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to ease the administration of users (promoting regular users to administrators)
For system administrators
We will enable user administration in the EasyAdmin backend
Whereas currently we are promoting users to administrators using command line
Closes #166