fe UT

zhaoyongjie · Nov 19, 2023 · c77e9ec · c77e9ec
1 parent 223ba8b
commit c77e9ec
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 1 deletion.
diff --git a/...frontend/src/explore/components/controls/DateFilterControl/tests/DateFilterLabel.test.tsx b/...frontend/src/explore/components/controls/DateFilterControl/tests/DateFilterLabel.test.tsx
@@ -106,3 +106,34 @@ test('Open and close popover', () => {
   expect(defaultProps.onClosePopover).toHaveBeenCalled();
   expect(screen.queryByText('Edit time range')).not.toBeInTheDocument();
 });
+
+test('Should render shortcuts frame', () => {
+  render(
+    setup(
+      defaultProps,
+      mockStore({
+        common: {
+          conf: {
+            DEFAULT_TIME_FILTER: "DATETRUNC(DATETIME('today'), WEEK) : today",
+            TIME_FILTER_SHORTCUTS: [
+              ['Current week', "DATETRUNC(DATETIME('today'), WEEK) : today"],
+              [
+                'Current month(MTD)',
+                "DATETRUNC(DATETIME('today'), MONTH) : today",
+              ],
+              [
+                'Current year(YTD)',
+                "DATETRUNC(DATETIME('today'), YEAR) : today",
+              ],
+            ],
+          },
+        },
+      }),
+    ),
+  );
+
+  userEvent.click(screen.getByTestId('time-range-trigger'));
+  expect(screen.getByText('Current week')).toBeInTheDocument();
+  expect(screen.getByText('Current month(MTD)')).toBeInTheDocument();
+  expect(screen.getByText('Current year(YTD)')).toBeInTheDocument();
+});
diff --git a/superset-frontend/src/explore/components/controls/DateFilterControl/utils/dateFilterUtils.ts b/superset-frontend/src/explore/components/controls/DateFilterControl/utils/dateFilterUtils.ts
@@ -63,7 +63,7 @@ export const guessFrame = (
   if (customTimeRangeDecode(timeRange).matchedFlag) {
     return 'Custom';
   }
-  if (shortcuts.filter(s => s[1] === timeRange)) {
+  if (shortcuts.filter(s => s[1] === timeRange).length > 0) {
     return 'Shortcuts';
   }
   return 'Advanced';