Create engine that works with GlideV4 RC #114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glide 4 will change handling of methods and put them inside a RequestOptions object: https://bumptech.github.io/glide/doc/migrating.html
gejiaheng
suggested changes
Sep 21, 2017
| * {@link ImageEngine} implementation using Glide. | ||
| */ | ||
|
|
||
| public class GlideEngine implements ImageEngine { |
There was a problem hiding this comment.
The file name is GlideV4Engine, but the class name is GlideEngine
|
I'm not digging into this issue. But something you should pay attention to is how you make Glide v3.x and v4.x coexist? They have the same dependency group name and artifact name. |
|
@gejiaheng Hey any progress for this? |
|
Since ImageEngine is a Interface .Anyone who use Glide V4 can realize a GlideEngine for V4 by himself . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Glide 4 will change handling of methods and put them inside a RequestOptions object: https://bumptech.github.io/glide/doc/migrating.html
I took the GlideEngine.java file and applied the changes needed to make it work with Glide V4