Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalizing and simplifying Cuda precompilation logging #77

Merged
merged 4 commits into from
Oct 20, 2023

Conversation

zsogitbe
Copy link
Contributor

Replacing Console write with Logger write. The library should not write directly to the Console. Simplification: precompileProgressWriter function is then not needed.

Replacing Console write with Logger write. The library should not write directly to the Console. Simplification: precompileProgressWriter function is then not needed.
For calling the library from an other application we must provide a callback mechanism that the caller app can handle messages and progress reporting professionally.
Copy link
Owner

@zhongkaifu zhongkaifu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zsogitbe ,

What's this Callback used for ? I didn't find any code uses it in the project. Can you please point it out ? Thanks.

@zsogitbe
Copy link
Contributor Author

Hi @zsogitbe ,

What's this Callback used for ? I didn't find any code uses it in the project. Can you please point it out ? Thanks.

There is no example in the distribution yet which uses this callback. The callback mechanism is important if you want to allow the use of the library in professional applications. For example, a Windows Forms application could use the library and present the messages with this callback nicely in a text box. Writing in the Console would not work at all in this case.
But even in an other type of Console application would this be important where the application would print the messages, for example, on different parts of the screen. Etc.

@zhongkaifu zhongkaifu merged commit 3e99859 into zhongkaifu:master Oct 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants