Fail Codecov check on upload error #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
TheJulianJES
force-pushed
the
tjj/codecov_fail_ci_if_error
branch
from
ffb197d to
52681e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
fail_ci_if_erroroption to the Codecov action.By default, the Codecov check succeeds, even if the upload fails. This makes the check fail if the upload fails.
Otherwise, the failing Codecov upload is easily missed.
We're now using codecov-action v4 (#17) which should be "completely stable" for runs on the main repo where the
CODECOV_TOKENsecret is available.On PRs made from forks, we might still see rare failures, as those need to use tokenless uploads which are constrained by the GitHub API rate limit.
To notice those (rare) upload failures, we probably want to fail the Codecov upload check to make it clear that the upload failed. The codecov logs include an ETA of when tokenless uploads are available again. So, after 10 minutes or so, the upload job can then easily be restarted.