Skip to content

Commit

Permalink
Wait for BDBCommissioningStatus.Success instead of no remaining modes
Browse files Browse the repository at this point in the history
  • Loading branch information
puddly committed Apr 26, 2020
1 parent 18448dc commit a39c4fb
Showing 1 changed file with 2 additions and 9 deletions.
11 changes: 2 additions & 9 deletions zigpy_znp/zigbee/application.py
Original file line number Diff line number Diff line change
Expand Up @@ -300,23 +300,16 @@ async def startup(self, auto_form=False):
)

# Start commissioning and wait until it's done
comm_notification = await self._znp.request_callback_rsp(
await self._znp.request_callback_rsp(
request=c.APPConfigCommands.BDBStartCommissioning.Req(
Mode=c.app_config.BDBCommissioningMode.NetworkFormation
),
RspStatus=t.Status.Success,
callback=c.APPConfigCommands.BDBCommissioningNotification.Callback(
partial=True,
RemainingModes=c.app_config.BDBRemainingCommissioningModes.NONE,
partial=True, Status=c.app_config.BDBCommissioningStatus.Success,
),
)

# XXX: Commissioning fails for me yet I experience no issues
if comm_notification.Status != c.app_config.BDBCommissioningStatus.Success:
LOGGER.warning(
"BDB commissioning did not succeed: %s", comm_notification.Status
)

async def update_network(
self,
*,
Expand Down

0 comments on commit a39c4fb

Please sign in to comment.