Skip to content

Commit

Permalink
Merge pull request #305 from zillow/yunw/remove-redundant-generatename
Browse files Browse the repository at this point in the history
[minor][bugfix] Remove redundant generateName
  • Loading branch information
cloudw authored Aug 20, 2024
2 parents 97ab1e6 + d514484 commit 350e017
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions metaflow/plugins/aip/aip.py
Original file line number Diff line number Diff line change
Expand Up @@ -291,10 +291,9 @@ def _create_workflow_yaml(
# Note the name has to follow k8s format.
# self.name is typically CamelCase as it's python class name.
# generateName contains a sanitized version of self.name from aip.compiler
default_workflow_name = workflow["metadata"].pop("generateName").rstrip("-")
workflow["metadata"]["name"] = (
sanitize_k8s_name(name)
if name
else workflow["metadata"].pop("generateName").rstrip("-")
sanitize_k8s_name(name) if name else default_workflow_name
)

# Service account is added through webhooks.
Expand Down

0 comments on commit 350e017

Please sign in to comment.