Merge pull request #427 from zilverline/sequent-8

Sequent 8

.github/workflows/rspec.yml

@@ -21,22 +21,12 @@ jobs:
     strategy:
       matrix:
         include:
-          - ruby-version: 3.3
+          - ruby-version: '3.3'
             gemfile: 'ar_7_2'
-          - ruby-version: 3.3
+          - ruby-version: '3.3'
             gemfile: 'ar_7_1'
-          - ruby-version: 3.2
+          - ruby-version: '3.2'
             gemfile: 'ar_7_1'
-          - ruby-version: 3.2
-            gemfile: 'ar_7_0'
-          - ruby-version: 3.1.3
-            gemfile: 'ar_7_0'
-          - ruby-version: 3.0.5
-            gemfile: 'ar_7_0'
-          - ruby-version: 3.0.5
-            gemfile: 'ar_6_1'
-          - ruby-version: 3.0.5
-            gemfile: 'ar_6_0'
     env:
       BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
     services:
@@ -88,15 +78,15 @@ jobs:
       - name: Run integration tests simple
         run: |
           cd integration-specs/simple
-          bundle exec rspec    
+          bundle exec rspec
 
   integration_rails:
     env:
       POSTGRES_DB: sequent_integration_test_db
     runs-on: ubuntu-latest
     services:
       postgres:
-        image: postgres:12
+        image: postgres:14
         env:
           POSTGRES_USER: sequent
           POSTGRES_PASSWORD: sequent
@@ -123,4 +113,3 @@ jobs:
           bundle exec rake sequent:db:create_event_store
           bundle exec rake sequent:db:create_view_schema
           bundle exec rspec spec
-      

.rubocop.yml

@@ -10,17 +10,17 @@
 # See https://github.com/rubocop-hq/rubocop/blob/master/manual/configuration.md
 
 AllCops:
+  TargetRubyVersion: 3.2
   SuggestExtensions:
     rubocop-rake: false
     rubocop-rspec: false
+  NewCops: enable
   Exclude:
     # default
     - '**/node_modules/**/*'
     - '**/vendor/**/*'
     - '**/.git/**/*'
     # sequent
-    - '**/sequent/generator/template_aggregate/**/*'
-    - '**/sequent/generator/template_project/**/*'
     - 'db/sequent_schema.rb'
     - 'docs/**/*'
     - 'integration-specs/rails-app/bin/*'
@@ -67,8 +67,10 @@ Layout/LineLength:
   Max: 120
   AutoCorrect: true
 
+Gemspec/AddRuntimeDependency:
+  Enabled: true
 Gemspec/RequiredRubyVersion:
-  Enabled: false
+  Enabled: true
 
 ##
 # Metrics (all disabled; we have our own opinion on this)
@@ -144,9 +146,21 @@ Naming/MethodParameterName:
 ##
 # Lint
 ##
+Lint/DuplicateSetElement:
+  Enabled: true
+
+Lint/ItWithoutArgumentsInBlock:
+  Enabled: true
+
+Lint/LiteralAssignmentInCondition:
+  Enabled: true
+
 Lint/UriEscapeUnescape:
   Enabled: false # TODO enable
 
+Lint/UselessNumericOperation:
+  Enabled: true
+
 Lint/SuppressedException:
   AllowComments: true
 
@@ -241,7 +255,24 @@ Layout/BlockAlignment:
   Enabled: true
   EnforcedStyleAlignWith: start_of_block
 
-# TODO Ruby 3.0
+
+Style/MapIntoArray:
+  Enabled: true
+
+Style/RedundantInterpolationUnfreeze:
+  Enabled: true
+
+Style/SendWithLiteralMethodName:
+  Enabled: true
+
+Style/SingleLineDoEndBlock:
+  Enabled: true
+
+Style/SuperArguments:
+  Enabled: true
+
+Style/SuperWithArgsParentheses:
+  Enabled: true
 
 Style/HashTransformKeys:
   Enabled: false
@@ -278,219 +309,29 @@ Style/SoleNestedConditional:
 
 Style/EvalWithLocation:
   Enabled: false
-
-Layout/SpaceBeforeBrackets: # (new in 1.7)
-  Enabled: false
-Lint/AmbiguousAssignment: # (new in 1.7)
-  Enabled: false
-Lint/DeprecatedConstants: # (new in 1.8)
-  Enabled: false
-Lint/DuplicateBranch: # (new in 1.3)
-  Enabled: false
-Lint/DuplicateRegexpCharacterClassElement: # (new in 1.1)
-  Enabled: false
 Lint/EmptyBlock: # (new in 1.1)
   Enabled: false
 Lint/EmptyClass: # (new in 1.3)
   Enabled: false
-Lint/LambdaWithoutLiteralBlock: # (new in 1.8)
-  Enabled: false
-Lint/NoReturnInBeginEndBlocks: # (new in 1.2)
-  Enabled: false
-Lint/NumberedParameterAssignment: # (new in 1.9)
-  Enabled: false
-Lint/OrAssignmentToConstant: # (new in 1.9)
-  Enabled: false
-Lint/RedundantDirGlobSort: # (new in 1.8)
-  Enabled: false
 Lint/SymbolConversion: # (new in 1.9)
   Enabled: false
-Lint/ToEnumArguments: # (new in 1.1)
-  Enabled: false
-Lint/TripleQuotes: # (new in 1.9)
-  Enabled: false
-Lint/UnexpectedBlockArity: # (new in 1.5)
-  Enabled: false
-Lint/UnmodifiedReduceAccumulator: # (new in 1.1)
-  Enabled: false
 Style/ArgumentsForwarding: # (new in 1.1)
   Enabled: false
-Style/CollectionCompact: # (new in 1.2)
-  Enabled: false
 Style/DocumentDynamicEvalDefinition: # (new in 1.1)
   Enabled: false
-Style/EndlessMethod: # (new in 1.8)
-  Enabled: false
-Style/HashExcept: # (new in 1.7)
-  Enabled: false
-Style/IfWithBooleanLiteralBranches: # (new in 1.9)
-  Enabled: false
 Style/NegatedIfElseCondition: # (new in 1.2)
   Enabled: false
-Style/NilLambda: # (new in 1.3)
-  Enabled: false
-Style/RedundantArgument: # (new in 1.4)
-  Enabled: false
-Style/SwapValues: # (new in 1.1)
-  Enabled: false
-Style/StringConcatenation:
-  Enabled: false
-Style/HashEachMethods:
-  Enabled: false
-Lint/RedundantSafeNavigation:
-  Enabled: false
-Style/HashTransformValues:
-  Enabled: false
-Lint/FloatComparison:
-  Enabled: false
 Style/ClassVars:
   Enabled: false
-Layout/LineEndStringConcatenationIndentation: # new in 1.18
-  Enabled: false
-Lint/AmbiguousRange: # new in 1.19
-  Enabled: false
-Lint/EmptyInPattern: # new in 1.16
-  Enabled: false
-Naming/InclusiveLanguage: # new in 1.18
-  Enabled: false
-Style/HashConversion: # new in 1.10
-  Enabled: false
-Style/InPatternThen: # new in 1.16
-  Enabled: false
-Style/MultilineInPatternThen: # new in 1.16
-  Enabled: false
-Style/QuotedSymbols: # new in 1.16
-  Enabled: false
-Style/RedundantSelfAssignmentBranch: # new in 1.19
-  Enabled: false
-Style/StringChars: # new in 1.12
-  Enabled: false
-# new since rubny 3.2
-Gemspec/DeprecatedAttributeAssignment: # new in 1.30
-  Enabled: false
 Gemspec/DevelopmentDependencies: # new in 1.44
   Enabled: false
-Gemspec/RequireMFA: # new in 1.23
-  Enabled: false
-Layout/LineContinuationLeadingSpace: # new in 1.31
-  Enabled: false
-Layout/LineContinuationSpacing: # new in 1.31
-  Enabled: false
-Lint/AmbiguousOperatorPrecedence: # new in 1.21
-  Enabled: false
-Lint/ConstantOverwrittenInRescue: # new in 1.31
-  Enabled: false
-Lint/DuplicateMagicComment: # new in 1.37
-  Enabled: false
-Lint/DuplicateMatchPattern: # new in 1.50
-  Enabled: false
-Lint/IncompatibleIoSelectWithFiberScheduler: # new in 1.21
-  Enabled: false
-Lint/MixedCaseRange: # new in 1.53
-  Enabled: false
-Lint/NonAtomicFileOperation: # new in 1.31
-  Enabled: false
-Lint/RedundantRegexpQuantifiers: # new in 1.53
-  Enabled: false
-Lint/RefinementImportMethods: # new in 1.27
-  Enabled: false
-Lint/RequireRangeParentheses: # new in 1.32
-  Enabled: false
-Lint/RequireRelativeSelfPath: # new in 1.22
-  Enabled: false
-Lint/UselessRescue: # new in 1.43
-  Enabled: false
-Lint/UselessRuby2Keywords: # new in 1.23
-  Enabled: false
-Metrics/CollectionLiteralLength: # new in 1.47
-  Enabled: false
 Naming/BlockForwarding: # new in 1.24
   Enabled: false
 Security/CompoundHash: # new in 1.28
   Enabled: false
-Security/IoMethods: # new in 1.22
-  Enabled: false
-Style/ArrayIntersect: # new in 1.40
-  Enabled: false
-Style/ComparableClamp: # new in 1.44
-  Enabled: false
-Style/ConcatArrayLiterals: # new in 1.41
-  Enabled: false
-Style/DataInheritance: # new in 1.49
-  Enabled: false
-Style/DirEmpty: # new in 1.48
-  Enabled: false
-Style/EmptyHeredoc: # new in 1.32
-  Enabled: false
-Style/EnvHome: # new in 1.29
-  Enabled: false
-Style/ExactRegexpMatch: # new in 1.51
-  Enabled: false
 Style/FetchEnvVar: # new in 1.28
   Enabled: false
-Style/FileEmpty: # new in 1.48
-  Enabled: false
-Style/FileRead: # new in 1.24
-  Enabled: false
-Style/FileWrite: # new in 1.24
-  Enabled: false
-Style/MagicCommentFormat: # new in 1.35
-  Enabled: false
-Style/MapCompactWithConditionalBlock: # new in 1.30
-  Enabled: false
-Style/MapToHash: # new in 1.24
-  Enabled: false
-Style/MapToSet: # new in 1.42
-  Enabled: false
-Style/MinMaxComparison: # new in 1.42
-  Enabled: false
-Style/NestedFileDirname: # new in 1.26
-  Enabled: false
-Style/NumberedParameters: # new in 1.22
-  Enabled: false
-Style/NumberedParametersLimit: # new in 1.22
-  Enabled: false
 Style/ObjectThen: # new in 1.28
   Enabled: false
-Style/OpenStructUse: # new in 1.23
-  Enabled: false
-Style/OperatorMethodCall: # new in 1.37
-  Enabled: false
-Style/RedundantArrayConstructor: # new in 1.52
-  Enabled: false
-Style/RedundantConstantBase: # new in 1.40
-  Enabled: false
-Style/RedundantCurrentDirectoryInPath: # new in 1.53
-  Enabled: false
-Style/RedundantDoubleSplatHashBraces: # new in 1.41
-  Enabled: false
-Style/RedundantEach: # new in 1.38
-  Enabled: false
-Style/RedundantFilterChain: # new in 1.52
-  Enabled: false
-Style/RedundantHeredocDelimiterQuotes: # new in 1.45
-  Enabled: false
-Style/RedundantInitialize: # new in 1.27
-  Enabled: false
-Style/RedundantLineContinuation: # new in 1.49
-  Enabled: false
-Style/RedundantRegexpArgument: # new in 1.53
-  Enabled: false
-Style/RedundantRegexpConstructor: # new in 1.52
-  Enabled: false
-Style/RedundantStringEscape: # new in 1.37
-  Enabled: false
-Style/ReturnNilInPredicateMethodDefinition: # new in 1.53
-  Enabled: false
-Style/SelectByRegexp: # new in 1.22
-  Enabled: false
-Style/YAMLFileRead: # new in 1.53
-  Enabled: false
-Style/HashSyntax:
-  Enabled: false
-Lint/RedundantRequireStatement:
-  Enabled: false
-Lint/AmbiguousRegexpLiteral:
-  Enabled: false
-Style/SafeNavigation:
-  Enabled: false
+Style/SafeNavigationChainLength:
+  Enabled: false