Include default gems 'logger' and 'csv' #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logger gem will no longer be part of the default gems starting from Ruby 3.5.0, the csv gem will no longer be part of the default gems starting from Ruby 3.4.0. Adding these gems to the gemspec should silence the warnings Ruby 3.3 currently generates on every usage. ``` /Users/koen/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/activesupport-7.1.4/lib/active_support/logger_silence.rb:5: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. You can add logger to your Gemfile or gemspec to silence this warning. /Users/koen/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/sequent-7.1.1/lib/sequent.rb:5: warning: csv was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.4.0. You can add csv to your Gemfile or gemspec to silence this warning. ```
lvonk
approved these changes
Oct 9, 2024
lvonk
reviewed
Oct 9, 2024
werdlerk
force-pushed
the
include-default-gems
branch
from
c13519d to
ff39a60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding these gems to the gemspec should silence the warnings Ruby 3.3(.5) currently generates on every command.