Support ActiveRecord/Rails 8.0 #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evsasse
commented
Jan 1, 2025
lib/sequent/support/database.rb
Outdated
| @@ -49,7 +49,7 @@ def self.establish_connection(db_config, db_config_overrides = {}) | |||
| db_config = db_config.deep_merge( | |||
| Sequent.configuration.primary_database_key => db_config_overrides, | |||
| ).stringify_keys | |||
| if ActiveRecord::VERSION::MAJOR >= 7 && ActiveRecord::VERSION::MINOR < 1 | |||
| if ActiveRecord::VERSION::MAJOR == 7 && ActiveRecord::VERSION::MINOR < 1 | |||
There was a problem hiding this comment.
This is the main change I needed to make it work here for now... Still exploring it a bit deeper against our own app.
And running the tests on this repo with ActiveRecord 8.x also confirm this issue.
There was a problem hiding this comment.
We no longer support ActiveRecord before 7.1 so I think this if can be completely removed?
There was a problem hiding this comment.
Makes sense... Done ✅
lib/sequent/support/database.rb
Outdated
| @@ -49,7 +49,7 @@ def self.establish_connection(db_config, db_config_overrides = {}) | |||
| db_config = db_config.deep_merge( | |||
| Sequent.configuration.primary_database_key => db_config_overrides, | |||
| ).stringify_keys | |||
| if ActiveRecord::VERSION::MAJOR >= 7 && ActiveRecord::VERSION::MINOR < 1 | |||
| if ActiveRecord::VERSION::MAJOR == 7 && ActiveRecord::VERSION::MINOR < 1 | |||
There was a problem hiding this comment.
We no longer support ActiveRecord before 7.1 so I think this if can be completely removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would be awesome if we can also back-port this to a
v7.2.1WDYT? @lvonk