Skip to content

feat: enable using the zlib-rs backend through flate2 #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hasenbanck
Copy link

This backend is exposed since flate2 v1.0.29.

This backend is exposed since flate2 v1.0.29.
@hasenbanck
Copy link
Author

  • Build adn test fails, because the new optional feature would be require rustc 1.75 (zlib-rs), where as the pipeline currently uses 1.73.
  • style_and_docs check fails because of files not touched by this PR.
  • check_minimal_versions won't compile, because the test uses "cargo check --all-features", which will break flate2 (flate 2's CI does choose the backends selectively).

Not sure how to progress with this PR under such constraints.

@Pr0methean Pr0methean enabled auto-merge February 25, 2025 21:42
@Pr0methean
Copy link
Member

Pr0methean commented Feb 25, 2025

You'll probably need to increase the MSRV to 1.75 in Cargo.toml, and either (a) update the CI workflow to replace --all-features with all the maximal compatible sets of individual features, or (b) fix flate2 upstream so that it builds with --all-features.

@Pr0methean Pr0methean disabled auto-merge February 25, 2025 21:59
Copy link
Member

@Pr0methean Pr0methean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the Conversation tab.

@Pr0methean Pr0methean added Please fix failing tests Tests are failing with this change; please fix them. caused by dependency labels Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
caused by dependency Please fix failing tests Tests are failing with this change; please fix them.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants