Sort values in AdminDynamicFieldScreenConfiguration

[eyazi]

Proposed change

In „Assignment of dynamic fields to screens“ (AdminDynamicFieldScreenConfiguration) screens and default columns get sorted by the key of the setting and not the value of the setting.

This PR adds proper sorting. The „sorting“ doesn't look that bad on the screenshots below, but if you add your own modules where the key differs from the screen name, the view gets confusing very fast.

Type of change

• '1 - 🚀 feature'

Additional information

Old:

New:

Checklist

• The code change is tested and works locally.(❗)
• There is no commented out code in this PR.(❕)
• You improved or added new unit tests.(❕)
• Local ZnunyCodePolicy passed.(❕)
• Local UnitTests / Selenium passed.(❕)
• GitHub workflow CI (UnitTests / Selenium) passed.(❗)

[dennykorsukewitz]

Hi @eyazi ,
thanks for your PR.

Please, keep your fork up-to-date with the upstream repository.
Syncing a fork 🚀 🆙

Regards 🚀

[NiklasSchmitt]

Hi @eyazi,

thank you for your PR. I would like to accept and merge it but first you have to cleanup the code that the ZnunyCodePolicy and all other pipelines successes. Also, please sync your fork with the upstream repository.

Best regards,
Niklas Schmitt ☕ 🚀

[dennykorsukewitz]

index 0767c2f927..a292d6b14f 100644
--- a/Kernel/Modules/AdminDynamicFieldScreenConfiguration.pm
+++ b/Kernel/Modules/AdminDynamicFieldScreenConfiguration.pm
@@ -278,7 +278,9 @@ sub _ShowOverview {

     $LayoutObject->Block( Name => 'Overview' );

-    for my $DynamicFieldScreen ( sort { $DynamicFieldScreens{$a} cmp $DynamicFieldScreens{$b} } keys %DynamicFieldScreens ) {
+    for my $DynamicFieldScreen ( sort { $DynamicFieldScreens{$a} cmp $DynamicFieldScreens{$b} }
+        keys %DynamicFieldScreens )
+    {
         $LayoutObject->Block(
             Name => 'DynamicFieldScreenOverviewRow',
             Data => {
@@ -288,7 +290,9 @@ sub _ShowOverview {
         );
     }

-    for my $DefaultColumnsScreen ( sort { $DefaultColumnsScreens{$a} cmp $DefaultColumnsScreens{$b} } keys %DefaultColumnsScreens ) {
+    for my $DefaultColumnsScreen ( sort { $DefaultColumnsScreens{$a} cmp $DefaultColumnsScreens{$b} }
+        keys %DefaultColumnsScreens )
+    {
         $LayoutObject->Block(
             Name => 'DefaultColumnsScreenOverviewRow',
             Data => {
(END)

[dennykorsukewitz]

@eyazi sorry for that.

Today the code policy is bit ...