Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide all password fields when backend without db pass is used #404

Open
wants to merge 2 commits into
base: rel-6_5-dev
Choose a base branch
from

Conversation

pboguslawski
Copy link
Contributor

Proposed change

When using auth backend that does not require password from db (i.e.
basic auth) Znuny hides correctly password input in agent and customer
preferences (Kernel/Output/HTML/Preferences/Password.pm) but does not
hide password fields in AdminUser nor AdminCustomerUser screens. This
mod hides password fields on these screens also.

Type of change

  • '1 - 🐞 bug 🐞' - Bugfix (non-breaking change which fixes an issue)

Additional information

Author-Change-Id: IB#1110411

Checklist

  • The code change is tested and works locally.(❗)
  • There is no commented out code in this PR.(❕)
  • You improved or added new unit tests.(❕)
  • Local ZnunyCodePolicy passed.(❕)
  • Local UnitTests / Selenium passed.(❕)
  • GitHub workflow CI (UnitTests / Selenium) passed.(❗)

When using auth backend that does not require password from db (i.e.
basic auth) Znuny hides correctly password input in agent and customer
preferences (Kernel/Output/HTML/Preferences/Password.pm) but does not
hide password fields in AdminUser nor AdminCustomerUser screens. This
mod hides password fields on these screens also.

Author-Change-Id: IB#1110411
Author-Change-Id: IB#1110411
@dennykorsukewitz dennykorsukewitz added the 1 - 🐞 bug 🐞 An issue with the system. label Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - 🐞 bug 🐞 An issue with the system.
Development

Successfully merging this pull request may close these issues.

2 participants