Bad Content-ID formatting handling in DetectAttachment filter fixed #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Znuny throws `Use of uninitialized value $ImageID in quotemeta at [...]DetectAttachment.pm line 65` error when importing e-mail message with inline image with Content-ID header value without <>. Such formatting is not allowed by RFC https://datatracker.ietf.org/doc/html/rfc2392#section-2 but is accepted Znuny in https://github.com/znuny/Znuny/blob/rel-6_0/Kernel/System/Ticket/Article/Backend/MIMEBase/ArticleStorageFS.pm#L372 so it should tolerate it also in DetectAttachment.pm. This mod fixes it. I also reverts 61cfc74 because HTML tags and attributes are case insensitive: znuny@61cfc74#commitcomment-110812670 Related: https://datatracker.ietf.org/doc/html/rfc2392#section-2 Fixes: 61cfc74 Author-Change-Id: IB#1114877
Fixes: 1581fff Author-Change-Id: IB#1114877
Author-Change-Id: IB#1114877
Author-Change-Id: IB#1114877
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Znuny throws
error when importing e-mail message with inline image with Content-ID header value without <>. Such formatting is not allowed by RFC https://datatracker.ietf.org/doc/html/rfc2392#section-2 but is accepted Znuny in
https://github.com/znuny/Znuny/blob/rel-6_0/Kernel/System/Ticket/Article/Backend/MIMEBase/ArticleStorageFS.pm#L372
so it should tolerate it also in DetectAttachment.pm. This mod fixes it.
I also reverts 61cfc74 because HTML tags and attributes are case insensitive:
61cfc74#commitcomment-110812670
Type of change
Additional information
Replaces: #192
Related: https://datatracker.ietf.org/doc/html/rfc2392#section-2
Fixes: 61cfc74
Author-Change-Id: IB#1114877
Checklist