Fixed SearchInArchive parameter not used in the fulltext search of the toolbar. #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkaldung
added
1 - 🐞 bug 🐞
dennykorsukewitz
requested changes
Sep 26, 2023
dennykorsukewitz
changed the title
NiklasSchmitt
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
SearchInArchive search parameter isn't used in the toolbar search anymore, because the block 'ToolBarSearchFulltext' has been removed and the condition to check if the parameter should be added didn't get any Data anymore.
Additionally, the test (Selenium/Output/ToolBar/TicketSearchFulltext.t) failed because of this, and because the search menu had to be opened to select fulltext-search.
1 - 🐞 bug 🐞
Checklist