Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Efflux: Disable logging of plaintext passwords in debugging mode (CVE-2024-43444) #588

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

eyazi
Copy link
Contributor

@eyazi eyazi commented Aug 27, 2024

Proposed change

Disable the logging of plaintext passwords in debugging mode.

Type of change

  • 1 - 🐞 bug 🐞

Additional information

This is inspired by CVE-2024-43444. I'd not consider this a security patch, as the debugging mode can only be enabled by changing the source code. And if you have access to the source code, you can debug anything.

Checklist

  • The code change is tested and works locally.(❗)
  • There is no commented out code in this PR.(❕)
  • You improved or added new unit tests.(❕)
  • Local ZnunyCodePolicy passed.(❕)
  • Local UnitTests / Selenium passed.(❕)
  • GitHub workflow CI (UnitTests / Selenium) passed.(❗)

@eyazi eyazi changed the title Efflux: Disable logging of plaintext passwords in debugging mode Efflux: Disable logging of plaintext passwords in debugging mode (CVE-2024-43444) Aug 27, 2024
@eyazi
Copy link
Contributor Author

eyazi commented Aug 27, 2024

I’ve made some changes to make the PR more consistent.

In my understanding of security, an application should never write passwords in plain text to a log file. If crypt type is set to plain, for whatever reason, even passwords retrieved from the database are logged in plain text.
However, I understand that there might be different perspectives on this, especially since you need to set the minimum log level to notice and enable the logging directly in the code.

@eyazi eyazi force-pushed the efflux-disable-plaintext-password-logging branch from 58ba4d7 to aa65bbb Compare August 29, 2024 01:18
@dennykorsukewitz dennykorsukewitz added the 3 - wait for reviewer Znuny, it's your turn. label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - wait for reviewer Znuny, it's your turn.
Development

Successfully merging this pull request may close these issues.

2 participants