Portuguese Date Fixed .pm

[Bashizz]

Proposed change

There are some users that like to put the language in Portuguese from Portugal, the problem was that the date appeared as "DateFormatInvalid" due to the date not being applied correctly (not applied at all), so I basically just copied the brazilian one and pasted it over the already existing code

🐞 bug

Breaking change

It doesn't break

Additional information

Checklist

• The code change is tested and works locally.(❗)
• There is no commented out code in this PR.(❕)
• You improved or added new unit tests.(❕)
• Local ZnunyCodePolicy passed.(❕)
• Local UnitTests / Selenium passed.(❕)
• GitHub workflow CI (UnitTests / Selenium) passed.(❗)

[rkaldung]

Verified with public sources:

• Mostly (dd/mm/yyyy) and (dd-mm-yyyy); some newer documents use (yyyy-mm-dd)
• Standard described in NP EN 28601

[rkaldung]

@mbethke Please check if this applies to both current versions

[dennykorsukewitz]

This error was caused by this commit:

f310c1d#diff-16809a2529d876b4ee527dc118d6583f58fad440fe3d2f7cf1157b77d4b405d0L27-L33

[mbethke]

@dennykorsukewitz I'm not entirely sure what state to use here. @Bashizz' change certainly fixes the bug in that it now works ;) But it uses the Brazilian format which seems to be neither the most common in Portugal nor conforming to ISO-8601.
The translators at the EU commission noted (already 20 years ago, but it's the latest I could find) that NP EN 28601 just recommends the ISO format %Y-%M-%D but it would only be a good idea for something like a form or invoice, not necessarily for texts closer to the oral form where they'd prefer what we had before, %D de %B de %Y.
Znuny translations are all over the place on whether DateFormatLong should include a weekday name—21 languages don't, 27 do. I tend towards "do".
Looking at the other translation files I also noticed that both zh_TW and zh_CN still have the leading space in DateFormatLong, and Korean has the same problems as non-Brazilian Portuguese, so some more comprehensive fixing is needed.

Proposal for pt.pm, basically what we had before but dropping the uncommon hyphen before %T in DateInputFormatLong:

    $Self->{DateFormat}          = '%Y-%M-%D %T';
    $Self->{DateFormatLong}      = '%A, %D de %B de %Y, %T';
    $Self->{DateFormatShort}     = '%Y-%M-%D';
    $Self->{DateInputFormat}     = '%Y-%M-%D';
    $Self->{DateInputFormatLong} = '%Y-%M-%D %T';

@rkaldung there hadn't been any changes to DateFormat between the rel-6_5 branch and the before the above commit from September so it will be fine to apply fixes to both 6.5.x and 7.1.

[mbethke]

Internal issue is 1007

[dennykorsukewitz]

Hi @Bashizz ,
thanks for your PR.

Approved 👍

We have created an issue internally and will adapt the format a little.

Thank you very much, keep up the good work
Regards 🚀