Skip to content

Commit

Permalink
Remove references to dipact.appspot.com
Browse files Browse the repository at this point in the history
  • Loading branch information
John McDowell committed May 15, 2023
1 parent de32775 commit 0dcc368
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 12 deletions.
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ and via chat at the #development channel on our [Discord server](https://discord

This is evolving, and not fully followed, but some guidelines:

* Use [Pretty](https://prettier.io/) to format the code. I use [vim-prettier](https://github.com/prettier/vim-prettier) which changes some settings, I think. Let's discuss how to solve that if someone wants to use Pretty with different settings - I'm totally open to changing this.
* Use CamelCase (or camelCase), not snake_case. I know JavaScript often uses snake_case, but it seems React uses CamelCase, so let's go with that.
* Use inline styles for small local changes, if possible. Save global CSS for themes or global changes.
- Use [Pretty](https://prettier.io/) to format the code. I use [vim-prettier](https://github.com/prettier/vim-prettier) which changes some settings, I think. Let's discuss how to solve that if someone wants to use Pretty with different settings - I'm totally open to changing this.
- Use CamelCase (or camelCase), not snake_case. I know JavaScript often uses snake_case, but it seems React uses CamelCase, so let's go with that.
- Use inline styles for small local changes, if possible. Save global CSS for themes or global changes.

### Technology

Expand All @@ -48,7 +48,7 @@ a new [http.FileSystem](https://golang.org/pkg/net/http/#FileSystem) using
### Deploying

The [deploy script](https://github.com/zond/dipact/blob/master/.github/workflows/deploy.yml) causes
the latest version to be pushed to https://dipact.appspot.com/ on each new push.
the latest version to be pushed to https://diplicity.com/ on each new push.

Pushing branches with sensible names to https://github.com/zond/dipact causes them to be pushed to
https://[branch-name]-dot-dipact.appspot.com/ on each new push.
https://[branch-name].diplicity.com/ on each new push.
9 changes: 2 additions & 7 deletions packages/web-app/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,14 +80,9 @@ if (window.Wrapper) {
gtag("set", { client: "browser" });
}

if (
window.location.href.indexOf("https://dipact.appspot.com") === 0 ||
window.location.href.indexOf("https://diplicity.com") === 0
) {
if (window.location.href.indexOf("https://diplicity.com") === 0) {
gtag("set", { api: "prod" });
} else if (
window.location.href.indexOf("https://beta-dot-dipact.appspot.com") === 0
) {
} else if (window.location.href.indexOf("https://beta.diplicity.com") === 0) {
gtag("set", { api: "beta" });
} else {
gtag("set", { api: "unknown" });
Expand Down

3 comments on commit 0dcc368

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage report for packages/common

St.❔
Category Percentage Covered / Total
πŸ”΄ Statements 51.11% 758/1483
πŸ”΄ Branches 31.72% 144/454
πŸ”΄ Functions 28.78% 99/344
πŸ”΄ Lines 52.12% 638/1224

Test suite run success

95 tests passing in 11 suites.

Report generated by πŸ§ͺjest coverage report action from 0dcc368

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage report for packages/native-app

St.❔
Category Percentage Covered / Total
🟒 Statements 100% 262/262
🟒 Branches 100% 144/144
🟒 Functions 100% 98/98
🟒 Lines 100% 260/260

Test suite run success

199 tests passing in 30 suites.

Report generated by πŸ§ͺjest coverage report action from 0dcc368

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage report for packages/web-app

St.❔
Category Percentage Covered / Total
🟒 Statements 98.89% 355/359
🟒 Branches 97.27% 178/183
🟒 Functions 98.36% 120/122
🟒 Lines 98.77% 321/325

Test suite run success

240 tests passing in 27 suites.

Report generated by πŸ§ͺjest coverage report action from 0dcc368

Please sign in to comment.