ENH: Display SC information on snackbar #447
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgxd
force-pushed
the
enh/snackbar-sc-star
branch
from
58f286a to
474c276
Compare
|
Looks simple and nice to me, but @johnpooch is main frontend developer so I'll let him decide :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
*after the province name to the snackbar text on click if the province is an SC.At times, units may block the icon on the province, making it difficult to identify (especially when playing a variant for the first time)
Not sure how to test this, but I've browsed finished games of different variants and this patch seems to work as expected.
P.S. Thank you for developing / hosting this service, it is very sleek 😃