Coloured SCs #177
Open
Coloured SCs #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the first test of "Beta" map. Let's see if this works
Elegant orders needs to reference a pattern in the SVG. Added it here to test.
- Changed White SCs to named SC layer - Reduced size of units - Changed some SC positions.
This reverts commit de7d99e.
This reverts commit c17e050.
- Split the SC foreground in two layers. - One layer is called ColorSCs - Each object in this layer is called 'proSC' (pro = province). These objects can be called from the client and coloured. - There is a layer above it called 'ColorSCs_foreground'. - Objects in this layer are ornamental, making sure the 'shape' fits exactly. I've added these to Maharajah and Spice Islands Beta's as well, to test before we push this. If it works, I'll need to change ALL the maps (but that's not a bad thing!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work that will works towards this style - a balance between visibility and aesthetic.
It requires new SCs for all maps (although it will work for maps that don't have this).
We can use one of the Beta maps (e.g. Maharajah) which are already using this scheme. If successful, I'll update this SC with all the maps one-by-one.