itemBox: fix creator row removed on label click #5137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- do not add regular label click handling that refocuses itemTree/reader (d3cee95) to creator rows, since their labels should just open the creator type dropdown on click. Having focus moved from itemBox to itemTree/reader when an empty creator is present would remove it. With this, an empty creator row will remain. - do not blur currently focused field when the creator type dropdown closes via "blur-on-hidden" class. That logic was added to make sure that focus does not land on the dropdown (which keeps all row's icons visible after popup goes away). Instead, prevent focus via event.preventDefault on mousedown event. Now, when the popup appears, the currently focused field just remains focused. Fixes: zotero#5117
abaevbog
force-pushed
the
5117_itembox_creatorLabel_focus
branch
from
bb64469 to
29e45a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not add regular label click handling that refocuses itemTree/reader (d3cee95) to creator rows, since their labels should just open the creator type dropdown on click. Having focus moved from itemBox to itemTree/reader when an empty creator is present would remove it. With this, an empty creator row will remain.
do not blur currently focused field when the creator type dropdown closes via "blur-on-hidden" class. That logic was
added to make sure that focus does not land on the dropdown (which keeps all row's icons visible after popup goes away). Instead, prevent focus via
event.preventDefault()onmousedownevent. Now, when the popup appears, the currently focused field just remains focused.Fixes: #5117
Screen.Recording.2025-03-19.at.4.02.35.PM.mov