Skip to content

fix: Set memory limit for javap #4141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025
Merged

fix: Set memory limit for javap #4141

merged 2 commits into from
May 30, 2025

Conversation

pj892031
Copy link
Contributor

Description

The start.sh script didn't provide a configuration for heap memory in the call of the javap application. It means the default values were taken (1GB). The requirement is 3MB with JDK8 and JDK17. This PR sets 4MB as the initial size and 16 MB as the maximum.

The omitted configuration could generate an issue with the system with limited resources, and in the same way, it is not necessary to allocate so much memory for this command. It is just to check what version of Java is in use.

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

Signed-off-by: Pavel Jareš <[email protected]>
@pablocarle
Copy link
Contributor

BTW why not a fixed size heap for this?

@pj892031
Copy link
Contributor Author

BTW why not a fixed size heap for this?

Because I wanted to have a reserve for a future version, anyway, it allocates the space that is required and shouldn't allocate more for the treatment. If some new version will require more (I assume up to a few dozen %), it will allocate the next 4MB... Actually, it is more hope than sure, but it could be more efficient.

Copy link

@pj892031 pj892031 merged commit fcb021f into v3.x.x May 30, 2025
50 of 52 checks passed
@pj892031 pj892031 deleted the reboot/javap-memory-limit branch May 30, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants