fix: always call layer_state_set_user #403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before commit b46f5e2, layer_state_set_kb was only defined if MOONLANDER_USER_LEDS was not set. With MOONLANDER_USER_LEDS set, the default layer_state_set_kb provided by QMK takes care of calling layer_state_set_user. After that commit, layer_state_set_kb is defined unconditionally, but most of its body is still ifdef'd out if MOONLANDER_USER_LEDS is set. That includes layer_state_set_user, which looks like an oversight. Run layer_state_set_user unconditionally. This is the same fix as zsa#396 for voyager. It looks like the other ZSA keyboards do not have the same problem. Alternatively, we could go back to the old approach of defining the function conditionally, but this makes it a little harder to reintroduce the same problem.
|
If you closed this PR because there is a problem with it, can you please clarify what it is? (#396 did get merged, and this is the same fix for a different keyboard...) |
|
I'm also wondering why this was closed, without this defining PS: Maybe updating the readme to reflect the renaming of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before commit b46f5e2, layer_state_set_kb was only defined if MOONLANDER_USER_LEDS was not set. With MOONLANDER_USER_LEDS set, the default layer_state_set_kb provided by QMK takes care of calling layer_state_set_user.
After that commit, layer_state_set_kb is defined unconditionally, but most of its body is still ifdef'd out if MOONLANDER_USER_LEDS is set. That includes layer_state_set_user, which looks like an oversight.
Run layer_state_set_user unconditionally.
This is the same fix as #396 for voyager. It looks like the other ZSA keyboards do not have the same problem.
Alternatively, we could go back to the old approach of defining the function conditionally, but this makes it a little harder to reintroduce the same problem.
Types of Changes
Issues Fixed or Closed by This PR
Checklist